[webkit-reviews] review denied: [Bug 183577] Resource Load Statistics: Immediately forward cookie access at user interaction when there's an opener document : [Attachment 335639] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied John Wilander
<wilander at apple.com>'s request for review:
Bug 183577: Resource Load Statistics: Immediately forward cookie access at user
interaction when there's an opener document
https://bugs.webkit.org/show_bug.cgi?id=183577

Attachment 335639: Patch

https://bugs.webkit.org/attachment.cgi?id=335639&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 335639
  --> https://bugs.webkit.org/attachment.cgi?id=335639
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335639&action=review

Looks like the patch is missing NetworkStorageSession changes!

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:371
> +	  
parentProcessConnection()->send(Messages::NetworkProcessProxy::StorageAccessReq
uestResult(networkStorageSession->hasStorageAccess(resourceDomain,
firstPartyDomain, frameID, pageID), contextId), 0);

It looks like you are missing the change to NetworkStorageSession that renames
'hasStorageAccessForFrame' -> 'hasStorageAccess'.