[webkit-reviews] review granted: [Bug 183575] Add label on github when exporting wpt tests to w3c/web-platform-test repo : [Attachment 335627] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Brendan McLoughlin
<brendan at bocoup.com>'s request for review:
Bug 183575: Add label on github when exporting wpt tests to
w3c/web-platform-test repo
https://bugs.webkit.org/show_bug.cgi?id=183575

Attachment 335627: Patch

https://bugs.webkit.org/attachment.cgi?id=335627&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 335627
  --> https://bugs.webkit.org/attachment.cgi?id=335627
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335627&action=review

> Tools/Scripts/webkitpy/w3c/common.py:42
> +WEBKIT_EXPORT_PR_LABEL = 'webkit-export'

common.py is imported from Chromium.
Ideally, we would not want to change this file so that we can easily reimport
it from Chromium.
We can probably move it to test_export.py.

> Tools/Scripts/webkitpy/w3c/test_exporter.py:181
>	   pr_number = self._github.create_pr(self._wpt_fork_remote + ':' +
self._branch_name, self._commit_message, self._commit_message + "\n" +
description)

Would create_pr always succeed, or are there some cases where it might not be
successful, in which case we should add some error handling?