[webkit-reviews] review granted: [Bug 183430] Stop using SDK conditionals to control feature definitions : [Attachment 335280] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Tim Horton <thorton at apple.com>'s request for
review:
Bug 183430: Stop using SDK conditionals to control feature definitions
https://bugs.webkit.org/show_bug.cgi?id=183430

Attachment 335280: Patch

https://bugs.webkit.org/attachment.cgi?id=335280&action=review




--- Comment #10 from mitz at webkit.org ---
Comment on attachment 335280
  --> https://bugs.webkit.org/attachment.cgi?id=335280
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335280&action=review

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:304
> +ENABLE_VIDEO_PRESENTATION_MODE =
$(ENABLE_VIDEO_PRESENTATION_MODE_$(PLATFORM_NAME));
> +ENABLE_VIDEO_PRESENTATION_MODE_iphoneos = ENABLE_VIDEO_PRESENTATION_MODE;
> +ENABLE_VIDEO_PRESENTATION_MODE_iphonesimulator =
ENABLE_VIDEO_PRESENTATION_MODE;

This changes something for non-iOS Cocoa Touch platforms, right?

> Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:331
> +ENABLE_WEB_RTC_iphoneos[arch=arm64*] = ENABLE_WEB_RTC;
> +ENABLE_WEB_RTC_iphonesimulator[arch=x86_64] = ENABLE_WEB_RTC;

Not sure these architecture conditionals are still necessary.