[webkit-reviews] review granted: [Bug 183546] Put the DOM in IsoHeaps : [Attachment 335622] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 12 12:28:37 PDT 2018


Daniel Bates <dbates at webkit.org> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 183546: Put the DOM in IsoHeaps
https://bugs.webkit.org/show_bug.cgi?id=183546

Attachment 335622: the patch

https://bugs.webkit.org/attachment.cgi?id=335622&action=review




--- Comment #27 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 335622
  --> https://bugs.webkit.org/attachment.cgi?id=335622
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335622&action=review

Looks sane to me.

r=me

> Source/WebCore/dom/TemplateContentDocumentFragment.cpp:35
> +} // namespace WebCore

This is OK as-is. We tend to omit this inline comment when the source code for
the entire file fits easily on any modern desktop monitor. If you do decide to
remove this comment then please remove it from all the other added files in
this patch.


More information about the webkit-reviews mailing list