[webkit-reviews] review granted: [Bug 183549] REGRESSION(r211643): Dismissing WKActionSheet should not also dismiss its presenting view controller : [Attachment 335553] Really fix open source iOS builds.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 12 09:32:48 PDT 2018
Andy Estes <aestes at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 183549: REGRESSION(r211643): Dismissing WKActionSheet should not also
dismiss its presenting view controller
https://bugs.webkit.org/show_bug.cgi?id=183549
Attachment 335553: Really fix open source iOS builds.
https://bugs.webkit.org/attachment.cgi?id=335553&action=review
--- Comment #5 from Andy Estes <aestes at apple.com> ---
Comment on attachment 335553
--> https://bugs.webkit.org/attachment.cgi?id=335553
Really fix open source iOS builds.
View in context: https://bugs.webkit.org/attachment.cgi?id=335553&action=review
> Tools/TestWebKitAPI/ClassMethodSwizzler.mm:27
> +#include "config.h"
> +#include "ClassMethodSwizzler.h"
#import
> Tools/TestWebKitAPI/Tests/ios/ActionSheetTests.mm:26
> #include "config.h"
#import
> Tools/TestWebKitAPI/ios/TestWKWebViewController.h:26
> +#pragma once
No need for this.
> Tools/TestWebKitAPI/ios/TestWKWebViewController.mm:31
> +#include "config.h"
> +#include "TestWKWebViewController.h"
> +
> +#if PLATFORM(IOS)
> +
> +#include <wtf/BlockPtr.h>
#import
More information about the webkit-reviews
mailing list