[webkit-reviews] review granted: [Bug 183556] [Web Animations] Create keyframes for declarative animations based on backing Animation and RenderStyle objects : [Attachment 335567] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 183556: [Web Animations] Create keyframes for declarative animations based
on backing Animation and RenderStyle objects
https://bugs.webkit.org/show_bug.cgi?id=183556

Attachment 335567: Patch

https://bugs.webkit.org/attachment.cgi?id=335567&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 335567
  --> https://bugs.webkit.org/attachment.cgi?id=335567
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335567&action=review

> Source/WebCore/ChangeLog:9
> +	   animations() and transitions() functions during style resolution. We
add new methods on KeyframeEffectReadOnly to create blending keyframes, which

is blending keyframes a spec term? i'm not sure what it is supposed to mean

> Source/WebCore/ChangeLog:21
> +	   looking up the keyframes date obtained from the @keyframes rule with
this backing animation's name.

data

> Source/WebCore/animation/KeyframeEffectReadOnly.cpp:837
> +    return !m_blendingKeyframes.isEmpty();

return hasBlendingKeyframes()