[webkit-reviews] review granted: [Bug 183554] [Web Animations] Fix some WebAnimation lifecycle issues in preparation for declarative animations support : [Attachment 335564] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 12 02:59:52 PDT 2018


Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 183554: [Web Animations] Fix some WebAnimation lifecycle issues in
preparation for declarative animations support
https://bugs.webkit.org/show_bug.cgi?id=183554

Attachment 335564: Patch

https://bugs.webkit.org/attachment.cgi?id=335564&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 335564
  --> https://bugs.webkit.org/attachment.cgi?id=335564
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335564&action=review

> Source/WebCore/animation/WebAnimation.cpp:664
> +   
MicrotaskQueue::mainThreadQueue().append(std::make_unique<VoidMicrotask>([this,
protectedThis = makeRef(*this)] () {
> +	   this->performMicrotask();
> +    }));

No need for the this in []. Just use protectedThis->performMicrotask()


More information about the webkit-reviews mailing list