[webkit-reviews] review denied: [Bug 183527] [WebAuthN] Implement authenticatorMakeCredential with self attestation : [Attachment 335495] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 183527: [WebAuthN] Implement authenticatorMakeCredential with self
attestation
https://bugs.webkit.org/show_bug.cgi?id=183527

Attachment 335495: Patch

https://bugs.webkit.org/attachment.cgi?id=335495&action=review




--- Comment #7 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 335495
  --> https://bugs.webkit.org/attachment.cgi?id=335495
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335495&action=review

It looks like this is a combination of two separate patches. Can you please
correct the patch so we can do a clean review of each separately?

> Source/WebCore/ChangeLog:15
> +	   1. An helper class called LocalAuthenticator is crafted to represent
Apple platform attached authenticator, i.e.

"A helper class"

> Source/WebCore/ChangeLog:17
> +	   supports, such as different Keychain API capabilities and different
attestation frameworks.

"lacks some fundamental support, such as"

> Source/WebCore/ChangeLog:78
> +	   <rdar://problem/36459988>

Looks like you got some extra ChangeLog data in the file!

> Source/WebKit/ChangeLog:30
> +	   <rdar://problem/36459988>

Ditto!