[webkit-reviews] review granted: [Bug 183494] [webkitpy] Remove openssl command dependency. : [Attachment 335482] PATCH
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 9 16:57:30 PST 2018
Ryosuke Niwa <rniwa at webkit.org> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 183494: [webkitpy] Remove openssl command dependency.
https://bugs.webkit.org/show_bug.cgi?id=183494
Attachment 335482: PATCH
https://bugs.webkit.org/attachment.cgi?id=335482&action=review
--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 335482
--> https://bugs.webkit.org/attachment.cgi?id=335482
PATCH
View in context: https://bugs.webkit.org/attachment.cgi?id=335482&action=review
> Tools/Scripts/webkitpy/port/base.py:1015
> + use_tls=True,
port=websocket_server.PyWebSocket.DEFAULT_WSS_PORT,
private_key=private_key_file, certificate=certificate_file)
Nit: Wrong indentation. Always use 4 spaces.
More information about the webkit-reviews
mailing list