[webkit-reviews] review granted: [Bug 183526] Allow NavigationState to intercept requests and send them to SystemPreviewController : [Attachment 335466] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 183526: Allow NavigationState to intercept requests and send them to
SystemPreviewController
https://bugs.webkit.org/show_bug.cgi?id=183526

Attachment 335466: Patch

https://bugs.webkit.org/attachment.cgi?id=335466&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 335466
  --> https://bugs.webkit.org/attachment.cgi?id=335466
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335466&action=review

>>> Source/WebKit/UIProcess/Cocoa/NavigationState.mm:658
>>> +		    
page.systemPreviewController()->showPreview(navigationResponse->response().url(
));
>> 
>> It seems a bit weird to take over if the client explicitly wants to
download, and also weird to then go ahead with the download?
> 
> I agree. But we can't nicely cancel the download at this point. Ultimately,
we'll have a separate download client or logic that doesn't navigate.

Or a separate policy type?