[webkit-reviews] review granted: [Bug 183501] Unconditionalize more methods in VideoFullscreenInterface (and related classes) : [Attachment 335443] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 183501: Unconditionalize more methods in VideoFullscreenInterface (and
related classes)
https://bugs.webkit.org/show_bug.cgi?id=183501

Attachment 335443: Patch

https://bugs.webkit.org/attachment.cgi?id=335443&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 335443
  --> https://bugs.webkit.org/attachment.cgi?id=335443
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335443&action=review

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h:154
> +    bool isPlayingVideoInEnhancedFullscreen() const;

Huh, I thought we got rid of "EnhancedFullscreen". Can you change this to
something like "isPlayingVideoInPictureInPicture" as long as you are updating?