[webkit-reviews] review granted: [Bug 183498] Add new CSS env constants for use with fullscreen : [Attachment 335434] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 183498: Add new CSS env constants for use with fullscreen
https://bugs.webkit.org/show_bug.cgi?id=183498

Attachment 335434: Patch

https://bugs.webkit.org/attachment.cgi?id=335434&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 335434
  --> https://bugs.webkit.org/attachment.cgi?id=335434
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335434&action=review

> Source/WebCore/dom/ConstantPropertyMap.cpp:58
> +    static NeverDestroyed<AtomicString>
fullscreenInsetTopName("fullscreen-inset-top",
AtomicString::ConstructFromLiteral);
> +    static NeverDestroyed<AtomicString>
fullscreenAutoHideDelayName("fullscreen-auto-hide-delay",
AtomicString::ConstructFromLiteral);

I'm fine with these names for now, but we should start the standardization
process right away.