[webkit-reviews] review granted: [Bug 183483] RealtimeOutgoingAudioSource and RealtimeOutgoingVideoSource should be destroyed on the main thread : [Attachment 335427] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 9 09:33:21 PST 2018


Eric Carlson <eric.carlson at apple.com> has granted  review:
Bug 183483: RealtimeOutgoingAudioSource and RealtimeOutgoingVideoSource should
be destroyed on the main thread
https://bugs.webkit.org/show_bug.cgi?id=183483

Attachment 335427: Patch

https://bugs.webkit.org/attachment.cgi?id=335427&action=review




--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 335427
  --> https://bugs.webkit.org/attachment.cgi?id=335427
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335427&action=review

> Source/WebCore/testing/MockLibWebRTCPeerConnection.h:217
> +    bool SetTrack(webrtc::MediaStreamTrackInterface* track) final
> +    {
> +	   m_track = track;
> +	   return true;
> +    }

Is this related? A note in the ChangeLog about why this was changed would be
helpful.


More information about the webkit-reviews mailing list