[webkit-reviews] review granted: [Bug 183510] [GTK] Do not use WebKitDOMHTMLFormElement as argument of signal WebKitWebPage::will-submit-form : [Attachment 335416] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 183510: [GTK] Do not use WebKitDOMHTMLFormElement as argument of signal
WebKitWebPage::will-submit-form
https://bugs.webkit.org/show_bug.cgi?id=183510

Attachment 335416: Patch

https://bugs.webkit.org/attachment.cgi?id=335416&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 335416
  --> https://bugs.webkit.org/attachment.cgi?id=335416
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335416&action=review

> Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitWebPage.cpp:594
> +	* @form: the #WebKitDOMElement to be submitted

the #WebKitDOMElement to be submitted, which will always correspond to an
HTMLFormElement

> Tools/TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:385
> +    GUniquePtr<char> formID(webkit_dom_element_get_id(formElement));

Oops. I wish it was not transfer full. :( But I guess the ID can change at any
time.