[webkit-reviews] review granted: [Bug 183511] [Nicosia] Add threaded PaintingEngine implementation : [Attachment 335421] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 183511: [Nicosia] Add threaded PaintingEngine implementation
https://bugs.webkit.org/show_bug.cgi?id=183511

Attachment 335421: Patch

https://bugs.webkit.org/attachment.cgi?id=335421&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 335421
  --> https://bugs.webkit.org/attachment.cgi?id=335421
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335421&action=review

> Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp:49
> +    auto* taskData = static_cast<TaskData*>(data);

We could adopt the data here using unique_ptr.

> Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp:97
> +	       paintLayer(context, layer, sourceRect, mappedSourceRect,
targetRect,
> +		   contentsScale, buffer->supportsAlpha());

I think this could be one line

>
Source/WebCore/platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp:100
> +    g_thread_pool_push(m_threadPool, new TaskData { WTFMove(buffer),
WTFMove(paintingOperations) }, nullptr);

I guess this happens a lot, can we make TaskData fast allocated?