[webkit-reviews] review granted: [Bug 183500] Add basic synchronization capability to Nicosia::Buffer : [Attachment 335401] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 183500: Add basic synchronization capability to Nicosia::Buffer
https://bugs.webkit.org/show_bug.cgi?id=183500

Attachment 335401: Patch

https://bugs.webkit.org/attachment.cgi?id=335401&action=review




--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 335401
  --> https://bugs.webkit.org/attachment.cgi?id=335401
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335401&action=review

> Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp:58
> +    m_painting.state = PaintingState::InProgress;

Should we assert here that state as complete?

> Source/WebCore/platform/graphics/nicosia/NicosiaBuffer.cpp:64
> +    m_painting.state = PaintingState::Complete;

And here that is in progress?