[webkit-reviews] review granted: [Bug 183194] BuildbotBuildEntry for buildbot 0.9 uses incorrect buildrequestid : [Attachment 335060] Proposed patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 183194: BuildbotBuildEntry for buildbot 0.9 uses incorrect buildrequestid
https://bugs.webkit.org/show_bug.cgi?id=183194

Attachment 335060: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=335060&action=review




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 335060
  --> https://bugs.webkit.org/attachment.cgi?id=335060
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335060&action=review

> Websites/perf.webkit.org/tools/js/buildbot-syncer.js:24
> +	   this._buildRequestId = rawData['properties'] &&
rawData['properties'][syncer._buildRequestPropertyName] ?
> +				     
rawData['properties'][syncer._buildRequestPropertyName][0] : null;

Nit: Wrong indentation. '?' should be on line 24, and '?' should appear exactly
4 spaces to the right of this._buildRequestId.