[webkit-reviews] review denied: [Bug 183221] Telemetry for stalled webpage loads : [Attachment 335373] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Keith Rollin <krollin at apple.com>'s
request for review:
Bug 183221: Telemetry for stalled webpage loads
https://bugs.webkit.org/show_bug.cgi?id=183221

Attachment 335373: Patch

https://bugs.webkit.org/attachment.cgi?id=335373&action=review




--- Comment #27 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 335373
  --> https://bugs.webkit.org/attachment.cgi?id=335373
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335373&action=review

> Source/WebCore/platform/network/cf/ResourceError.h:58
> +	   mapPlatformError();

As commented earlier, I think this is not a good idea. We should obey the type
being given.

> Source/WebCore/platform/network/mac/ResourceErrorMac.mm:121
> +    mapPlatformError();

This is not needed since the constructor above already does it.

> Source/WebCore/platform/network/mac/ResourceErrorMac.mm:124
> +void ResourceError::mapPlatformError()

This claims to map platform error codes but tries to deal with cases where we
do not have a platform error, this is confusing.