[webkit-reviews] review granted: [Bug 183016] [Curl] Implement connection limit. : [Attachment 335369] PATCH

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 183016: [Curl] Implement connection limit.
https://bugs.webkit.org/show_bug.cgi?id=183016

Attachment 335369: PATCH

https://bugs.webkit.org/attachment.cgi?id=335369&action=review




--- Comment #9 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 335369
  --> https://bugs.webkit.org/attachment.cgi?id=335369
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=335369&action=review

> Source/WebCore/platform/network/curl/CurlContext.cpp:238
> +

If we call setMaxConnects once to a value and then setMaxConnects to -1,
shouldn't we update m_multiHandle as well?
If we only call it once, maybe maxConnects (and below parameters as well)
should be passed in CurlMultiHandle constructor.

> Source/WebCore/platform/network/curl/CurlContext.h:121
> +    CurlRequestScheduler& scheduler() { return *m_scheduler; }

If m_scheduler was a UniqueRef<CurlRequestScheduler>, there would be no need
for '*'.
A UniqueRef is just a unique_ptr that cannot have a null pointer.