[webkit-reviews] review granted: [Bug 183316] Web Inspector: Sources: add SourcesTabContentView and SourceSidebarPanel classes : [Attachment 335356] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 183316: Web Inspector: Sources: add SourcesTabContentView and
SourceSidebarPanel classes
https://bugs.webkit.org/show_bug.cgi?id=183316

Attachment 335356: Patch

https://bugs.webkit.org/attachment.cgi?id=335356&action=review




--- Comment #5 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 335356
  --> https://bugs.webkit.org/attachment.cgi?id=335356
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335356&action=review

r=me

> Source/WebInspectorUI/ChangeLog:57
> +	   added and the identifier changed from "resources" to "sources".

I think both this, and the previous comment, can be merged into the top-level
change log comment:

Add Sources tab and sidebar panel, which are copies of the corresponding
Resources classes.
The Sources tab is shown when it's enabled in the experimental settings. This
patch doesn't
remove existing Resources and Debugger tabs.