[webkit-reviews] review granted: [Bug 183482] Ensure default appearance for selection form control : [Attachment 335350] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 183482: Ensure default appearance for selection form control
https://bugs.webkit.org/show_bug.cgi?id=183482

Attachment 335350: Patch

https://bugs.webkit.org/attachment.cgi?id=335350&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 335350
  --> https://bugs.webkit.org/attachment.cgi?id=335350
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335350&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:340
> +    LocalDefaultSystemAppearance localAppearance;

Should this just be inside platformInactiveSelectionBackgroundColor, where we
presumably call to NSColor? Aren't there other callers?