[webkit-reviews] review granted: [Bug 183291] NSAnimation is not working in the WebContent process when WindowServer access is blocked. : [Attachment 335160] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 183291: NSAnimation is not working in the WebContent process when
WindowServer access is blocked.
https://bugs.webkit.org/show_bug.cgi?id=183291

Attachment 335160: Patch

https://bugs.webkit.org/attachment.cgi?id=335160&action=review




--- Comment #14 from Dean Jackson <dino at apple.com> ---
Comment on attachment 335160
  --> https://bugs.webkit.org/attachment.cgi?id=335160
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335160&action=review

I'm giving this an r+ but I think it would be better if we got the animation
data from AppKit rather than simulate it ourselves. That way, if/when AppKit
decides to tweak the animation function, we remain in sync.

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:382
> +	   auto t = elapsed / _duration;

We should probably have a guarantee that _duration is never 0.

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:418
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED < 101400
>      [self stopAnimation];
> +#else

It's a bit confusing that this calls stopAnimation on older OS versions, but
you implement a separate stopAnimation call on newer versions.