[webkit-reviews] review granted: [Bug 183450] [Win] Use __debugbreak for WTFBreakpointTrap : [Attachment 335296] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 183450: [Win] Use __debugbreak for WTFBreakpointTrap
https://bugs.webkit.org/show_bug.cgi?id=183450

Attachment 335296: Patch

https://bugs.webkit.org/attachment.cgi?id=335296&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 335296
  --> https://bugs.webkit.org/attachment.cgi?id=335296
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335296&action=review

r=me

> Source/WTF/wtf/Assertions.h:212
> +#else
>  #if ASAN_ENABLED

Change this into an "#elif ASAN_ENABLED" because these cases should all be
mutually exclusive.

> Source/WTF/wtf/Assertions.h:223
> +#endif // COMPILER(MSVC)

Remove this.