[webkit-reviews] review denied: [Bug 183422] webkitpy: Build ImageDiff if it is missing : [Attachment 335242] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 183422: webkitpy: Build ImageDiff if it is missing
https://bugs.webkit.org/show_bug.cgi?id=183422

Attachment 335242: Patch

https://bugs.webkit.org/attachment.cgi?id=335242&action=review




--- Comment #3 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 335242
  --> https://bugs.webkit.org/attachment.cgi?id=335242
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335242&action=review

> Tools/ChangeLog:12
> +	   ImageDiff is built with a different SDK than the rest of the WebKit
> +	   stack, and this frequently causes infrastructure failures where
ImageDiff
> +	   is missing on testers. To address this, we should automatically
build
> +	   ImageDiff if it is missing.
> +

I disagree with this premise. Testers should not be building software because
it adds complexity to the build system to ensure that testers build with the
same source revisions and toolchain among other issues and breaks with people's
intuition on the roles of builders and testers.