[webkit-reviews] review denied: [Bug 181973] Web Inspector: Styles Redesign: ensure that tabbing through the last section wraps back to the first : [Attachment 334330] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has denied Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 181973: Web Inspector: Styles Redesign: ensure that tabbing through the
last section wraps back to the first
https://bugs.webkit.org/show_bug.cgi?id=181973

Attachment 334330: Patch

https://bugs.webkit.org/attachment.cgi?id=334330&action=review




--- Comment #9 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 334330
  --> https://bugs.webkit.org/attachment.cgi?id=334330
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334330&action=review

r- for now. Comments on the behaviors I observed when testing:

Styles panel tabbing works great, with one small issue:

- Checking a pseudo-class checkbox then hitting tab focuses the first rule
after Style Attribute {}. I expected it to focus Style Attribute {}.

Computed panel tabbing feels pretty broken:

-Shift-tabbing from the first property name focuses the "visited" checkbox
(good). Tabbing again doesn't move the focus back to the property name, instead
the focus is lost. Hitting tab again will move the focus back to the property
name.
- Tabbing from the last item value in either the Properties section or
Variables sections adds a blank space at the end of the section.
- Checking the first pseudo-class checkbox then hitting tab should focus the
next doesn't focus anything. Tabbing again moves the focus to the filter bar, 
- Shift-tabbing from the filter bar
- Tabbing from the filter bar focuses checkboxes in order but the focus is lost
after that.
- The "Show All" checkbox isn't accessible by tabbing.

>
Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:585
> +		  
this._delegate.cssStyleDeclarationTextEditorStartEditingAdjacentRule(this,
true);

Nit:

const backward = true;
this._delegate.cssStyleDeclarationTextEditorStartEditingAdjacentRule(this,
backward);