[webkit-reviews] review denied: [Bug 183015] Web Inspector: Canvas tab: ensure that the Recording TreeOutline has a specified height for virtualization : [Attachment 334409] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has denied Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 183015: Web Inspector: Canvas tab: ensure that the Recording TreeOutline
has a specified height for virtualization
https://bugs.webkit.org/show_bug.cgi?id=183015

Attachment 334409: Patch

https://bugs.webkit.org/attachment.cgi?id=334409&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 334409
  --> https://bugs.webkit.org/attachment.cgi?id=334409
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334409&action=review

r-, because it looks like this breaks the recording tree outline:

1. Goto
https://developer.mozilla.org/en-US/docs/Web/API/Canvas_API/Tutorial/Basic_anim
ations
2. Record frames from "a looping panorama" demo
3. Open recording, expand first frame
  => No child elements

> Source/WebInspectorUI/UserInterface/Views/TreeOutline.js:716
> +	   if (!isNaN(this._virtualizedPreviousFirstItem) && Math.abs(firstItem
- this._virtualizedPreviousFirstItem) < numberVisible)

Why is this needed? The bug title/summary gives the impression that the problem
is with how TreeOutline is used in the CanvasSidebarPanel, not with TreeOutline
itself. Please add a clarifying comment to the change log.