[webkit-reviews] review granted: [Bug 183403] [JSC] Add more JSType based fast path for jsDynamicCast : [Attachment 335183] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 183403: [JSC] Add more JSType based fast path for jsDynamicCast
https://bugs.webkit.org/show_bug.cgi?id=183403

Attachment 335183: Patch

https://bugs.webkit.org/attachment.cgi?id=335183&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 335183
  --> https://bugs.webkit.org/attachment.cgi?id=335183
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335183&action=review

Nice work.  r=me if you resolve EWS failures.

> Source/JavaScriptCore/runtime/JSObject.h:1100
>  // storage to fully make use of the colloctor cell containing it.

Can you fix this typo as well: /colloctor/collector/.

> Source/JavaScriptCore/runtime/JSScope.h:43
> +    DECLARE_INFO;

I suspect that you need to use DECLARE_EXPORT_INFO here (see EWS build
failure).