[webkit-reviews] review granted: [Bug 183387] Prepare LLInt code to support pointer profiling. : [Attachment 335170] proposed patch.

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 183387: Prepare LLInt code to support pointer profiling.
https://bugs.webkit.org/show_bug.cgi?id=183387

Attachment 335170: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=335170&action=review




--- Comment #3 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 335170
  --> https://bugs.webkit.org/attachment.cgi?id=335170
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=335170&action=review

r=me

> Source/JavaScriptCore/llint/LLIntData.cpp:90
> +	       ExceptionHandlerPtrTag, // handleUncaughtException

This seems brittle. Could we auto-gen this or something like xmacros?

> Source/JavaScriptCore/offlineasm/ast.rb:932
> +	   when "tagReturnAddress", "untagReturnAddress"

FIXME?

> Source/JavaScriptCore/runtime/PtrTag.h:73
> +    inline constexpr T removeCodePtrTag(PtrType ptr) { return
bitwise_cast<T>(ptr); }

Weird indent.