[webkit-reviews] review denied: [Bug 183286] [ARM] Assembler warnings: "use of r13 is deprecated" : [Attachment 335097] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied  review:
Bug 183286: [ARM] Assembler warnings: "use of r13 is deprecated"
https://bugs.webkit.org/show_bug.cgi?id=183286

Attachment 335097: Patch

https://bugs.webkit.org/attachment.cgi?id=335097&action=review




--- Comment #9 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 335097
  --> https://bugs.webkit.org/attachment.cgi?id=335097
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335097&action=review

> Source/JavaScriptCore/offlineasm/arm.rb:239
> +    operation = case m.post_match
> +		   when "eq" then "eq"
> +		   when "neq" then "neq"
> +		   when "a" then "b"
> +		   when "aeq" then "beq"
> +		   when "b" then "a"
> +		   when "beq" then "aeq"
> +		   when "gt" then "lt"
> +		   when "gteq" then "lteq"
> +		   when "lt" then "gt"
> +		   when "lteq" then "gteq"
> +		   else
> +		       raise "unknown operation #{m.post_match}"
> +		   end

This is super weird style.

Please stick to 4 space indent.