[webkit-reviews] review granted: [Bug 183373] [Web Animations] Add a new CSSTransition subclass of WebAnimation : [Attachment 335114] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 6 10:40:56 PST 2018
Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 183373: [Web Animations] Add a new CSSTransition subclass of WebAnimation
https://bugs.webkit.org/show_bug.cgi?id=183373
Attachment 335114: Patch
https://bugs.webkit.org/attachment.cgi?id=335114&action=review
--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 335114
--> https://bugs.webkit.org/attachment.cgi?id=335114
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=335114&action=review
> Source/WebCore/animation/CSSTransition.cpp:40
> + auto& document = target.document();
> +
> + auto result = adoptRef(*new CSSTransition(document));
> +
> + return result;
Same comment as the other patch.
> Source/WebCore/animation/CSSTransition.h:50
> + CSSPropertyID m_transitionProperty;
> +
> +};
Extra blank line
More information about the webkit-reviews
mailing list