[webkit-reviews] review granted: [Bug 183354] Ensure system appearance is default for web content : [Attachment 335111] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 183354: Ensure system appearance is default for web content
https://bugs.webkit.org/show_bug.cgi?id=183354

Attachment 335111: Patch

https://bugs.webkit.org/attachment.cgi?id=335111&action=review




--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 335111
  --> https://bugs.webkit.org/attachment.cgi?id=335111
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335111&action=review

Please make sure EWS is green before landing.

> Source/WebCore/platform/mac/LocalDefaultSystemAppearance.h:44
> +    NSAppearance* m_savedSystemAppearance;

Star's on the wrong side.

> Source/WebCore/platform/mac/LocalDefaultSystemAppearance.mm:37
> +    m_savedSystemAppearance = [[NSAppearance currentAppearance] retain];

Why is m_savedSystemAppearance not a retainptr?