[webkit-reviews] review granted: [Bug 183371] [Web Animations] Add a new CSSAnimation subclass of WebAnimation : [Attachment 335104] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 183371: [Web Animations] Add a new CSSAnimation subclass of WebAnimation
https://bugs.webkit.org/show_bug.cgi?id=183371

Attachment 335104: Patch

https://bugs.webkit.org/attachment.cgi?id=335104&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 335104
  --> https://bugs.webkit.org/attachment.cgi?id=335104
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=335104&action=review

> Source/WebCore/animation/CSSAnimation.cpp:40
> +    auto& document = target.document();
> +
> +    auto result = adoptRef(*new CSSAnimation(document));
> +
> +    return result;

why not just return adoptRef(*new CSSAnimation(target.document());

> Source/WebCore/animation/CSSAnimation.h:42
> +    const String& animationName() const { return m_animationName; }

You have no way to set the animation name yet.