[webkit-reviews] review denied: [Bug 182869] [WinCairo] Add WKView and WKAPI for wincairo : [Attachment 334997] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Yousuke Kimoto
<Yousuke.Kimoto at sony.com>'s request for review:
Bug 182869: [WinCairo] Add WKView and WKAPI for wincairo
https://bugs.webkit.org/show_bug.cgi?id=182869

Attachment 334997: Patch

https://bugs.webkit.org/attachment.cgi?id=334997&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 334997
  --> https://bugs.webkit.org/attachment.cgi?id=334997
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334997&action=review

> Source/WebKit/UIProcess/API/C/win/WKView.cpp:65
> +void WKViewSetIsInWindow(WKViewRef viewRef, bool isInWindow)
> +{
> +    notImplemented();
> +}

Let's not add unimplemented API.

> Source/WebKit/UIProcess/API/C/win/WKView.cpp:112
> +void WKViewSetDrawsTransparentBackground(WKViewRef viewRef, bool
drawsTransparentBackground)
> +{
> +}

ditto.

> Source/WebKit/UIProcess/API/C/win/WKView.cpp:117
> +bool WKViewDrawsTransparentBackground(WKViewRef viewRef)
> +{
> +    return false;
> +}

This is also basically unimplemented.

> Source/WebKit/UIProcess/API/C/win/WKView.h:76
> +    WK_EXPORT void WKViewSetInitialFocus(WKViewRef view, bool forward);

forward is probably the wrong name here.