[webkit-reviews] review granted: [Bug 183309] Create analysis task should use build time as fallback when commit time is not available. : [Attachment 334946] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted dewei_zhu at apple.com's request for
review:
Bug 183309: Create analysis task should use build time as fallback when commit
time is not available.
https://bugs.webkit.org/show_bug.cgi?id=183309

Attachment 334946: Patch

https://bugs.webkit.org/attachment.cgi?id=334946&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 334946
  --> https://bugs.webkit.org/attachment.cgi?id=334946
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334946&action=review

> Websites/perf.webkit.org/public/privileged-api/create-analysis-task.php:97
> +    return $result ? ($result[0]['time'] ? $result[0]['time'] :
$result[0]['build_time']) : null;

Can't we just do $result[0]['time'] || $result[0]['build_time'] ?