[webkit-reviews] review requested: [Bug 183222] [webkitpy] Bugzilla class should use NetworkTransaction for network operations : [Attachment 334920] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 2 13:23:07 PST 2018


Aakash Jain <aakash_jain at apple.com> has asked  for review:
Bug 183222: [webkitpy] Bugzilla class should use NetworkTransaction for network
operations
https://bugs.webkit.org/show_bug.cgi?id=183222

Attachment 334920: Proposed patch

https://bugs.webkit.org/attachment.cgi?id=334920&action=review




--- Comment #4 from Aakash Jain <aakash_jain at apple.com> ---
Created attachment 334920

  --> https://bugs.webkit.org/attachment.cgi?id=334920&action=review

Proposed patch

Using method open_url() which uses NetworkTransaction for all
self.browser.open() 

Also reverting changes done in https://trac.webkit.org/changeset/229064/webkit
and using open_url() instead as this is cleaner approach.


More information about the webkit-reviews mailing list