[webkit-reviews] review granted: [Bug 183278] Automation: stale elements not detected when removed from the DOM : [Attachment 334885] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 183278: Automation: stale elements not detected when removed from the DOM
https://bugs.webkit.org/show_bug.cgi?id=183278

Attachment 334885: Patch

https://bugs.webkit.org/attachment.cgi?id=334885&action=review




--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 334885
  --> https://bugs.webkit.org/attachment.cgi?id=334885
Patch

I hope we don't have 1000's of nodes or this could get expensive. It would be
nice to just check the validity of the requested node, but I guess any node
could be requested via script. We'd have to find the web elements after
transforming JS payload to elements.

Let's just keep this version unless we think it's actually causing a
performance problem. I like simple and brute force when we can get away with
it.

r=me