[webkit-reviews] review granted: [Bug 183288] offlineasm: Use temporary file for generating assembly code : [Attachment 334897] Patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Dominik Inführ
<dinfuehr at igalia.com>'s request for review:
Bug 183288: offlineasm: Use temporary file for generating assembly code
https://bugs.webkit.org/show_bug.cgi?id=183288

Attachment 334897: Patch

https://bugs.webkit.org/attachment.cgi?id=334897&action=review




--- Comment #2 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 334897
  --> https://bugs.webkit.org/attachment.cgi?id=334897
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334897&action=review

One suggestion, otherwise r=me

> Source/JavaScriptCore/offlineasm/asm.rb:398
> +FileUtils.cp(tempFile, outputFlnm)

I think you want rename, not copy:
  http://ruby-doc.org/core-2.1.1/File.html#method-c-rename

If it follows UNIX convention then it'll be atomic.