[webkit-reviews] review granted: [Bug 183254] Converting a load to a download does not work with async policy delegates : [Attachment 334850] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 183254: Converting a load to a download does not work with async policy
delegates
https://bugs.webkit.org/show_bug.cgi?id=183254

Attachment 334850: Patch

https://bugs.webkit.org/attachment.cgi?id=334850&action=review




--- Comment #7 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 334850
  --> https://bugs.webkit.org/attachment.cgi?id=334850
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334850&action=review

> Source/WebCore/loader/DocumentLoader.cpp:789
> +    frameLoader()->checkContentPolicy(m_response, [this, protectedThis =
makeRef(*this), mainResourceLoader = WTFMove(mainResourceLoader)](PolicyAction
policy) {

I guess capturing mainResourceLoader in the lambda is to be extra safe that we
call didReceiveResponsePolicy on the exact same loader from which we called
markInAsyncResponsePolicyCheck.
Or is there some more subtlety there?