[webkit-reviews] review granted: [Bug 183143] [GTK] testRunner.setWindowIsKey() has no effect on the web process side in WebKit2 : [Attachment 334894] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 2 05:26:50 PST 2018
Carlos Garcia Campos <cgarcia at igalia.com> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 183143: [GTK] testRunner.setWindowIsKey() has no effect on the web process
side in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=183143
Attachment 334894: Patch
https://bugs.webkit.org/attachment.cgi?id=334894&action=review
--- Comment #9 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 334894
--> https://bugs.webkit.org/attachment.cgi?id=334894
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=334894&action=review
> Tools/WebKitTestRunner/PlatformWebView.h:118
> + GtkWidget *m_otherWindow;
{ nullptr };
> Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:45
> + , m_otherWindow(nullptr)
Adn we don't need this here.
More information about the webkit-reviews
mailing list