[webkit-reviews] review granted: [Bug 183246] REGRESSION(r222843): [HarfBuzz] Combining enclosed keycap not correctly handled : [Attachment 334818] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 1 12:15:57 PST 2018


Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 183246: REGRESSION(r222843): [HarfBuzz] Combining enclosed keycap not
correctly handled
https://bugs.webkit.org/show_bug.cgi?id=183246

Attachment 334818: Patch

https://bugs.webkit.org/attachment.cgi?id=334818&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 334818
  --> https://bugs.webkit.org/attachment.cgi?id=334818
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334818&action=review

> LayoutTests/platform/gtk/fast/text/combining-enclosing-keycap-expected.txt:1
> +Vector smash protection is enabled.

This shouldn't be in the expected results. Why is this in the expected results?
WTF?


More information about the webkit-reviews mailing list