[webkit-reviews] review requested: [Bug 183251] [CMake] Split JSC header copying into public and private targets : [Attachment 334835] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 1 12:02:31 PST 2018
Don Olmstead <don.olmstead at sony.com> has asked for review:
Bug 183251: [CMake] Split JSC header copying into public and private targets
https://bugs.webkit.org/show_bug.cgi?id=183251
Attachment 334835: Patch
https://bugs.webkit.org/attachment.cgi?id=334835&action=review
--- Comment #3 from Don Olmstead <don.olmstead at sony.com> ---
Created attachment 334835
--> https://bugs.webkit.org/attachment.cgi?id=334835&action=review
Patch
This patch splits the copying of headers into 2 separate targets, one for
public and one for private.
JavaScriptCore and WebKit have both public and private headers that need to be
installed. In this case LLIntOffsets technically needs access to the public
headers of JavaScriptCore before it is built. This makes the dependencies more
explicit.
More information about the webkit-reviews
mailing list