[webkit-reviews] review granted: [Bug 183231] Scrollbar preferences are ignored when the WebContent process doesn't have access to the WindowServer. : [Attachment 334821] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 183231: Scrollbar preferences are ignored when the WebContent process
doesn't have access to the WindowServer.
https://bugs.webkit.org/show_bug.cgi?id=183231

Attachment 334821: Patch

https://bugs.webkit.org/attachment.cgi?id=334821&action=review




--- Comment #9 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 334821
  --> https://bugs.webkit.org/attachment.cgi?id=334821
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334821&action=review

r=me

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:2518
> +		93500F3213FDE3BE0099EC24 /* NSScrollerImpDetails.h in Headers
*/ = {isa = PBXBuildFile; fileRef = 93500F3113FDE3BE0099EC24 /*
NSScrollerImpDetails.h */; settings = {ATTRIBUTES = (Private, ); }; };

Did you change this on purpose? Fine if you did, but sometimes Xcode shuffles
things around for arbitrary reasons (and you could revert this to make the
patch smaller and easier to apply)

> Source/WebKit/WebProcess/WebProcess.cpp:222
> +

Please revert this whitespace-only change.

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:65
> +#endif

We usually have these conditional includes in a separate area.