[webkit-reviews] review requested: [Bug 182891] [CMake] Replace AVFoundationSupport.py using CMake : [Attachment 334759] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has asked	for review:
Bug 182891: [CMake] Replace AVFoundationSupport.py using CMake
https://bugs.webkit.org/show_bug.cgi?id=182891

Attachment 334759: Patch

https://bugs.webkit.org/attachment.cgi?id=334759&action=review




--- Comment #13 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 334759
  --> https://bugs.webkit.org/attachment.cgi?id=334759
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334759&action=review

> Source/cmake/OptionsAppleWin.cmake:43
> +    set(CMAKE_REQUIRED_INCLUDES ${WEBKIT_LIBRARIES_INCLUDE_DIR})
> +    set(CMAKE_REQUIRED_LIBRARIES
> +	   "${WEBKIT_LIBRARIES_LINK_DIR}/CoreFoundation${DEBUG_SUFFIX}.lib"
> +	   "${WEBKIT_LIBRARIES_LINK_DIR}/AVFoundationCF${DEBUG_SUFFIX}.lib"
> +	   "${WEBKIT_LIBRARIES_LINK_DIR}/QuartzCore${DEBUG_SUFFIX}.lib"
> +    )
> +    
> +    WEBKIT_CHECK_HAVE_INCLUDE(HAVE_AVCF AVFoundationCF/AVCFBase.h)
> +
> +    if (HAVE_AVCF)
> +	   SET_AND_EXPOSE_TO_BUILD(USE_AVFOUNDATION ON)
> +    endif ()
> +
> +    WEBKIT_CHECK_HAVE_SYMBOL(HAVE_AVCF_LEGIBLE_OUTPUT
AVCFPlayerItemLegibleOutputSetCallbacks
"TargetConditionals.h;dispatch/dispatch.h;AVFoundationCF/AVFoundationCF.h;AVFou
ndationCF/AVCFPlayerItemLegibleOutput.h")
> +    WEBKIT_CHECK_HAVE_SYMBOL(HAVE_AVFOUNDATION_LOADER_DELEGATE
AVCFAssetResourceLoaderSetCallbacks
"TargetConditionals.h;dispatch/dispatch.h;AVFoundationCF/AVFoundationCF.h")
> +    WEBKIT_CHECK_HAVE_SYMBOL(HAVE_AVCFURL_PLAYABLE_MIMETYPE
AVCFURLAssetIsPlayableExtendedMIMEType
"TargetConditionals.h;dispatch/dispatch.h;AVFoundationCF/AVFoundationCF.h")
> +    WEBKIT_CHECK_HAVE_SYMBOL(HAVE_AVCFPLAYERITEM_CALLBACK_VERSION_2
kAVCFPlayerItemLegibleOutput_CallbacksVersion_2
"TargetConditionals.h;dispatch/dispatch.h;AVFoundationCF/AVFoundationCF.h")

On public apple win I am using have symbol rather than looking directly for the
include. The have symbol actually creates a C file and tries to compile and
link it. The ones expected for public apple win are present so things SHOULD
work for the internal apple build