[webkit-reviews] review granted: [Bug 183225] imported/w3c/web-platform-tests/html/browsers/windows/browsing-context.html fails with async policy delegates : [Attachment 334783] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 1 09:01:53 PST 2018


Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 183225:
imported/w3c/web-platform-tests/html/browsers/windows/browsing-context.html
fails with async policy delegates
https://bugs.webkit.org/show_bug.cgi?id=183225

Attachment 334783: Patch

https://bugs.webkit.org/attachment.cgi?id=334783&action=review




--- Comment #7 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 334783
  --> https://bugs.webkit.org/attachment.cgi?id=334783
Patch

Clients might use this delegate callback to update state about what iframe is
showing what URL, not to actually make a decision.  If you're willing to risk
breaking such apps, and if you'll keep an eye out for such regressions, I'll r+
this change.


More information about the webkit-reviews mailing list