[webkit-reviews] review granted: [Bug 182911] Remove monotonicallyIncreasingTime : [Attachment 334588] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 182911: Remove monotonicallyIncreasingTime
https://bugs.webkit.org/show_bug.cgi?id=182911

Attachment 334588: Patch

https://bugs.webkit.org/attachment.cgi?id=334588&action=review




--- Comment #23 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 334588
  --> https://bugs.webkit.org/attachment.cgi?id=334588
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=334588&action=review

I've skimmed over the entire diff and I don't see any obvious mistakes. Looks
like you've been pretty careful, and the code is clearly now safer than it was
before, so r=me. But you do need to get this acked by a WK2 owner before
landing.

> Source/WTF/wtf/MonotonicTime.h:49
> +    // Call this if you know for sure that the double represents time
according to the monotonic time
> +    // in second. It must be in seconds and it must be from the same time
source.

"Call this if you know for sure that the double represents monotonic time
according to the same time source as MonotonicTime. It must be in seconds."

> Source/WTF/wtf/cocoa/MemoryPressureHandlerCocoa.mm:162
> +	       // FIXME: The final argument `s_minimumHoldOffTime.seconds()`
seems wrong.
> +	       dispatch_source_set_timer(_timer_event_source,
dispatch_time(DISPATCH_TIME_NOW, seconds.seconds() * NSEC_PER_SEC),
DISPATCH_TIME_FOREVER, s_minimumHoldOffTime.seconds());

This needs a bug report, too. But I'm not actually sure that it's wrong... the
comment up above indicates that it's supposed to be seconds.