[webkit-reviews] review granted: [Bug 187211] Builtins and host functions should get their own structures. : [Attachment 344016] proposed patch.

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 187211: Builtins and host functions should get their own structures.
https://bugs.webkit.org/show_bug.cgi?id=187211

Attachment 344016: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=344016&action=review




--- Comment #7 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 344016
  --> https://bugs.webkit.org/attachment.cgi?id=344016
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=344016&action=review

Nice. r=me

> JSTests/stress/regress-187211.js:76
> +}

Can we also add a test for getById ICs? I’m guessing they will run into the
same problem of producing the wrong result

> Source/JavaScriptCore/runtime/JSFunction.cpp:73
> +    if (executable->isBuiltinFunction()) {

Might be worth an assert above that arrow functions aren’t Builtins? Or can
they be if they’re nested in a builtin? Or maybe it’s moot because they don’t
have a “prototype” property?