[webkit-reviews] review canceled: [Bug 187204] Split InlineTextBox::emphasisMarkExistsAndIsAbove() into two methods : [Attachment 343991] Patch v1

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(:ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 187204: Split InlineTextBox::emphasisMarkExistsAndIsAbove() into two
methods
https://bugs.webkit.org/show_bug.cgi?id=187204

Attachment 343991: Patch v1

https://bugs.webkit.org/attachment.cgi?id=343991&action=review




--- Comment #8 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 343991
  --> https://bugs.webkit.org/attachment.cgi?id=343991
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=343991&action=review

>> Source/WebCore/rendering/InlineFlowBox.cpp:1577
>>		const RenderStyle& childLineStyle = child->lineStyle();
> 
> If you want me to change the second line to something like this, let me know:
> 
>	      auto& childLineStyle = textBox->lineStyle();

Will change this here...

> Source/WebCore/rendering/InlineFlowBox.cpp:1625
>	       const RenderStyle& childLineStyle = child->lineStyle();

...and here.