[webkit-reviews] review denied: [Bug 186758] Correctly close the variable argument list : [Attachment 342925] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 30 14:30:02 PDT 2018

Michael Catanzaro <mcatanzaro at igalia.com> has denied Tomas Popela
<tpopela at redhat.com>'s request for review:
Bug 186758: Correctly close the variable argument list

Attachment 342925: Patch


--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 342925
  --> https://bugs.webkit.org/attachment.cgi?id=342925

View in context: https://bugs.webkit.org/attachment.cgi?id=342925&action=review

> Source/WTF/wtf/text/WTFString.cpp:466
>	   va_end(args);
> +	   va_end(argsCopy);

Good catch, Fujii. Surely this function should call va_end(argsCopy), as
Coverity suggests, but it should NOT call va_end(args).

> Source/WTF/wtf/text/WTFString.cpp:478
>      va_end(args);

This should be removed, as well.

More information about the webkit-reviews mailing list