[webkit-reviews] review granted: [Bug 187221] Port WTF to OS(FUCHSIA) : [Attachment 344017] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 30 12:39:21 PDT 2018

Yusuke Suzuki <utatane.tea at gmail.com> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 187221: Port WTF to OS(FUCHSIA)

Attachment 344017: Patch


--- Comment #2 from Yusuke Suzuki <utatane.tea at gmail.com> ---
Comment on attachment 344017
  --> https://bugs.webkit.org/attachment.cgi?id=344017

View in context: https://bugs.webkit.org/attachment.cgi?id=344017&action=review

r=me with nits.

> Source/WTF/wtf/FastMalloc.cpp:366

Can we have an implementation for Fuchsia?
If we can implement it (but if it is a bit complicated for this patch), adding
FIXME here is desirable.

> Source/WTF/wtf/RandomDevice.cpp:33
> +#if !OS(DARWIN) && !OS(FUCHSIA) && OS(UNIX)

We should have `OS(FUCHSIA)` guard in RandomDevice.h too not to have m_fd.

More information about the webkit-reviews mailing list