[webkit-reviews] review granted: [Bug 187206] Resource Load Statistics: Make network process calls only for the process pool that the page belongs to : [Attachment 343975] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted John Wilander <wilander at apple.com>'s
request for review:
Bug 187206: Resource Load Statistics: Make network process calls only for the
process pool that the page belongs to
https://bugs.webkit.org/show_bug.cgi?id=187206

Attachment 343975: Patch

https://bugs.webkit.org/attachment.cgi?id=343975&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 343975
  --> https://bugs.webkit.org/attachment.cgi?id=343975
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343975&action=review

r=me with nits.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1221
> +    if (auto webPage = WebProcessProxy::webPage(pageID)) {

auto*

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1224
> +    } else

I think I'd rather we do an early return:
auto* webPage = WebProcessProxy::webPage(pageID);
if (!webPage) {
    completionHandler(false);
    return;
}
auto& networkProcess = webPage->process().processPool().ensureNetworkProcess();
networkProcess.hasStorageAccessForFrame(m_sessionID, resourceDomain,
firstPartyDomain, frameID, pageID, WTFMove(completionHandler));

Same comments apply below.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp:1231
> +	  
processPool->networkProcess()->getAllStorageAccessEntries(m_sessionID,
WTFMove(completionHandler));

This is still wrong but I guess we can fix separately since you do not have a
pageID here.